aboutsummaryrefslogtreecommitdiff
path: root/dmenu.c
Commit message (Collapse)AuthorAgeFilesLines
* fix UB with the function iscntrl()Hiltjo Posthuma2022-03-261-1/+1
| | | | From commit 6818e07291f3b2913e687c8ec3d3fe4711724050 by NRK, thanks
* Revert "avoid redraw when there's no change"Hiltjo Posthuma2022-03-261-3/+2
| | | | | | This reverts commit 6818e07291f3b2913e687c8ec3d3fe4711724050. This broke keys such as ^W to delete-backward-word
* avoid redraw when there's no changeNRK2022-03-251-2/+3
| | | | | | | | | | | | | while i was timing the performance issue, i noticed that there was lots of random redrawing going on. turns out there were coming from here; if someone presses CTRL/ALT etc without pressing anything else, nothing will be inserted, so nothing will change. but the code will `break`, go down and do a needless redraw. this patch changes it to simply return if the keypress iscntrl() also avoid potential UB by casting *buf into an unsigned char.
* free all allocated items, use %zu for size_tNRK2022-03-251-3/+6
| | | | | `items` itself is not checked for NULL as calling free on NULL is defined to be a no-op.
* inputw: improve correctness and startup performanceNRK2022-03-251-10/+9
| | | | | | | | | | | | | | | | a massive amount of time inside readstdin() is spent trying to get the max input width and then put it into inputw, only for it to get clamped down to mw/3 inside setup(). it makes more sense to calculate inputw inside setup() once we have mw available. similar to the last patch, i see noticeable startup performance improvement: before -> after 160ms -> 60ms additionally this will take fallback fonts into account compared to the previous version, so it's not only more performant but also more correct.
* significantly improve performance on large stringsNRK2022-03-251-3/+10
| | | | | | | | | | | | | | | this replaces inefficient pattern of `MIN(TEXTW(..), n)` with drw_fontset_getwidth_clamp() instead, which is far more efficient when we only want up to a certain width. dumping a decently sized (unicode) emoji file into dmenu, I see the startup time drop significantly with this patch. before -> after 360ms -> 160ms this should also noticeably improve input latency (responsiveness) given that calcoffsets() and drawmenu() are pretty hot functions.
* remove false-positive warning for int comparison as boolHiltjo Posthuma2022-03-011-1/+1
| | | | | | Reported by Prathu Baronia <prathu.baronia@praton.me>, patch slightly changed. Thanks!
* code-style: rm newline (oops)Hiltjo Posthuma2022-02-081-1/+0
|
* revert using strcasestr and use a more optimized portable versionHiltjo Posthuma2022-02-081-1/+20
| | | | | | ... compared to the old cistrstr(). Thanks for the feedback!
* improve performance of case-insensitive matchingHiltjo Posthuma2022-02-071-12/+1
|
* add support for more keypad keysHiltjo Posthuma2021-08-091-0/+11
| | | | | | The keypad Enter key was already supported. On some keyboard layouts like my laptop the page-up and page-down key is more comfortable to use. This adds a few lines but no complexity.
* revert IME supportHiltjo Posthuma2019-03-031-12/+3
| | | | | | | dmenu will not handle IME support (st will, atleast for now). revert parts of commit 377bd37e212b1ec4c03a481245603c6560d0be22 this commit also broke input focus.
* improve xopenim error messageHiltjo Posthuma2019-02-121-1/+1
| | | | die() already prints a newline.
* fix crash when XOpenIM returns NULLHiltjo Posthuma2019-02-121-2/+11
| | | | for example when IME variables are set, but the program is not started (yet).
* Close when the embedding window is destroyedQuentin Rameau2019-02-041-1/+6
|
* Use slow path if stdin is a ttydok2019-01-271-3/+1
| | | | | If stdin is a tty and dmenu is ran with the fast option then it's impossible to close stdin because the keyboard is already grabbed.
* code-style for pledge: check the return code -1, not < 0Hiltjo Posthuma2018-05-251-1/+1
| | | | this is the proper idiom
* code-style for pledge(2)Hiltjo Posthuma2018-05-251-6/+5
| | | | feedback from Klemens, thanks
* Pledge on OpenBSDHiltjo Posthuma2018-05-251-0/+9
|
* Fix cursor drawn position with wide glyphsQuentin Rameau2018-04-221-1/+1
|
* Handle IME inputQuentin Rameau2018-04-221-1/+4
| | | | Thanks to nzl <uruabi@gmail.com> for the patch!
* Fix handling of input stringsHiltjo Posthuma2018-04-221-14/+21
|
* add key bindings for moving to the word start or endQuentin Rameau2018-03-131-0/+34
| | | | Mod1+b/^Left and Mod1+f/^Right
* Fix regression in 84a1bc5Hiltjo Posthuma2018-01-041-1/+2
| | | | | | Reported by Jochen Sprickerhof, thanks! Applied patch with minor change (only initialize `i` for XINERAMA).
* Instantiate j var outside #ifdef XINEMARA directive because it is used in ↵Vincent Carluer2018-01-041-3/+2
| | | | loop outside directive
* fix a possible free of a uninitialize variable in paste()Hiltjo Posthuma2017-11-031-4/+6
|
* init colors using SchemeLastHiltjo Posthuma2017-11-031-3/+2
| | | | this makes it slightly easier to add colors to schemes.
* Set class name on menu windowOmar Sandoval2017-11-031-0/+2
| | | | | | WM_CLASS is a standard ICCCM property which is used to identify windows. Window managers and compositors use it to allow per-application configurable behavior.
* Revert "fix input text matching"Andrew Gregory2016-12-111-1/+1
| | | | | | | This reverts commit 09d0a36e0370f7ca9bdb171bf93c5ac3131c5a92. Using strncmp with the length of the user input turns it into a prefix match rather than an exact match as it's supposed to be.
* Xinerama: correct variable declarations in preprocessor conditionalThomas Gardner2016-11-251-5/+6
|
* add embedding support with -w optionQuentin Rameau2016-10-141-12/+53
|
* dmenu.1: group single optionsQuentin Rameau2016-10-141-2/+2
|
* die() consistency: always add newlineHiltjo Posthuma2016-08-121-4/+4
|
* fix crash if negative monitor (< -1) was passedHiltjo Posthuma2016-07-261-2/+2
| | | | for example: dmenu -m '-9001'
* Revert "Print highlighted input text only on single match"Hiltjo Posthuma2016-07-261-13/+3
| | | | | | | This reverts commit a4053bc4e403ae57343f43b7e363a0911bba5a3a. My bad, was working on the wrong branch and accidently pushed it... *facepalm*
* Print highlighted input text only on single matchQuentin Rameau2016-07-261-3/+13
| | | | | | When the input text fully matches a single item, do not draw the item and highlight the input text to show that it matches an item in opposition to regular input text not matching anything.
* Partially revert 44c7de3: fix items text width offset calculationQuentin Rameau2016-07-251-2/+2
| | | | | Without this, we discard the item if it's longer than assigned width instead of truncating it.
* fix: Do not crash on e.g. dmenu < /dev/nullS. Gilles2016-06-281-1/+1
|
* import new drw from libsl and minor fixes.Markus Teich2016-06-031-79/+68
| | | | | | | | | - extract drawitem function (code deduplication) - fix bug where inputw was not correctly calculated from the widest item, but just from the one with the longest strlen() which is not the same. It's better now, but does not account for fallback fonts, since it would be too slow to calculate all the correct item widths on startup. - minor code style fixes (indentation, useless line breaks)
* Add config option for word delimitersQuentin Rameau2015-12-191-2/+4
| | | | | Let the user configure word boundaries other than ' ', only works with the portable character set.
* unboolify dmenuHiltjo Posthuma2015-11-081-8/+6
|
* fix: multimon: always spawn client on first monitor if specified with -m 0Hiltjo Posthuma2015-11-071-1/+1
| | | | | | | | | | | This was always broken. Reproduce: focus client on second monitor, spawn dmenu with -m 0. Result: Old wrong behaviour: dmenu spawns on second monitor (focused client). Now: dmenu spawns on specified monitor (first).
* free schemes as arrayHiltjo Posthuma2015-10-181-6/+6
| | | | this makes it slightly easier to add custom schemes aswell
* fix input text matchingQuentin Rameau2015-10-041-1/+1
| | | | just compare the size of the input string
* fix incorrect ordering of match resultsDavide Del Zompo2015-10-041-2/+3
| | | | look for exact matches comparing the user input against the item text
* fix paste from clipboard (ctrl+shift+y)Hiltjo Posthuma2015-10-041-0/+1
| | | | | | | | from Joshua Lloret on the ML: "attached is a small patch to enable pasting from clipboard, as well as primary. It seems like there was already code in there to allow this, but since there was never any case to match the upper case 'Y', that inline if would always evaluate to false."
* minor style fixHiltjo Posthuma2015-09-281-1/+2
|
* Remove function prototypes and reorder functions accordinglyFRIGN2015-09-281-80/+64
|
* Untypedef struct itemFRIGN2015-09-281-10/+9
| | | | | | Adds clarity. Typedefs for structs are definitely a discussion matter, but there's no reason to hide a simple data-structure behind a meaningless typedef.
* Fix the conversion from microseconds to nanosecondsQuentin Rameau2015-09-281-1/+1
|