fix a possible free of a uninitialize variable in paste()

1 files changed, 6 insertions, 4 deletions

diff --git a/dmenu.c b/dmenu.c
index 91330f1..eae5685 100644
--- a/dmenu.c
+++ b/dmenu.c
@@ -467,10 +467,12 @@ paste(void)
         Atom da;
 
         /* we have been given the current selection, now insert it into input */
-        XGetWindowProperty(dpy, win, utf8, 0, (sizeof text / 4) + 1, False,
-                           utf8, &da, &di, &dl, &dl, (unsigned char **)&p);
-        insert(p, (q = strchr(p, '\n')) ? q - p : (ssize_t)strlen(p));
-        XFree(p);
+        if (XGetWindowProperty(dpy, win, utf8, 0, (sizeof text / 4) + 1, False,
+                           utf8, &da, &di, &dl, &dl, (unsigned char **)&p)
+            == Success && p) {
+                insert(p, (q = strchr(p, '\n')) ? q - p : (ssize_t)strlen(p));
+                XFree(p);
+        }
         drawmenu();
 }