diff options
author | FRIGN <dev@frign.de> | 2016-10-02 00:10:45 +0200 |
---|---|---|
committer | Markus Teich <markus.teich@stusta.mhn.de> | 2016-10-10 20:40:13 +0200 |
commit | c96e725df0c449abb5f1f6a3b604f64fa69c4756 (patch) | |
tree | b464fc517f2fcdbfbbec5be746c615b1e247ecdb | |
parent | 6a1bd896356ae3b59053b5e458fdff62d076114b (diff) |
Use explicit strcmp() instead of inlining it
Makes it a tad more readable; the previous "optimization" will be done
by the compiler anyway.
-rw-r--r-- | slock.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -100,7 +100,7 @@ gethash(void) | |||
100 | hash = pw->pw_passwd; | 100 | hash = pw->pw_passwd; |
101 | 101 | ||
102 | #if HAVE_SHADOW_H | 102 | #if HAVE_SHADOW_H |
103 | if (hash[0] == 'x' && hash[1] == '\0') { | 103 | if (!strcmp(hash, "x")) { |
104 | struct spwd *sp; | 104 | struct spwd *sp; |
105 | if (!(sp = getspnam(pw->pw_name))) | 105 | if (!(sp = getspnam(pw->pw_name))) |
106 | die("slock: getspnam: cannot retrieve shadow entry. " | 106 | die("slock: getspnam: cannot retrieve shadow entry. " |
@@ -108,7 +108,7 @@ gethash(void) | |||
108 | hash = sp->sp_pwdp; | 108 | hash = sp->sp_pwdp; |
109 | } | 109 | } |
110 | #else | 110 | #else |
111 | if (hash[0] == '*' && hash[1] == '\0') { | 111 | if (!strcmp(hash, "*")) { |
112 | #ifdef __OpenBSD__ | 112 | #ifdef __OpenBSD__ |
113 | if (!(pw = getpwuid_shadow(getuid()))) | 113 | if (!(pw = getpwuid_shadow(getuid()))) |
114 | die("slock: getpwnam_shadow: cannot retrieve shadow entry. " | 114 | die("slock: getpwnam_shadow: cannot retrieve shadow entry. " |